Skip to content

Fix schema validation #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 21, 2025
Merged

Fix schema validation #345

merged 7 commits into from
May 21, 2025

Conversation

stellasia
Copy link
Contributor

@stellasia stellasia commented May 21, 2025 •
edited
Loading

Description

  • One test was wrong: we still want users to be able to provide entity types as strings (ie only labels)
  • While investigating, realized part of the code was not used, so removed a full else block
  • Also, it seems that having relationship_types=None in the prompt is interpreted as "do not extract relationships" by the LLM, so relationship_types is now removed if null (but not if empty)

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Note

Please provide an estimated complexity of this PR of either Low, Medium or High

Complexity:

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@stellasia stellasia marked this pull request as ready for review May 21, 2025 12:10
@stellasia stellasia requested a review from a team as a code owner May 21, 2025 12:10
oskarhane
oskarhane approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@stellasia stellasia merged commit b96a9bd into neo4j:main May 21, 2025
8 of 9 checks passed
@stellasia stellasia deleted the fix/schema branch June 16, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarhane oskarhane oskarhane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellasia @oskarhane